Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics.rb #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update metrics.rb #68

wants to merge 1 commit into from

Conversation

jindraj
Copy link

@jindraj jindraj commented Feb 5, 2020

add conditions on some keys that are not part of db.serverStatus() in mongodb version 4.2+

#67

The condition checking mongodb server version would be probably better, but I'm not 100% sure when it was removed and checking if the object has the specific keys seems also to be valid approach. Since it's used in the same file in other places.

Pull Request Checklist

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

add conditions on some keys that are not part of `db.serverStatus()` in mongodb version 4.2+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant