Issue #582: Simplify the options required in httpcli #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplified httpcli options by adding two parameters `positionalMethod` and `positionalUrl` which allow to create CLI requests without using `--method` and `--url`. * Handled all the possible cases when the user specifies both positional parameters and options. * Tested on MetricsHub.
NassimBtk
reviewed
Feb 18, 2025
metricshub-agent/src/main/java/org/sentrysoftware/metricshub/cli/HttpCli.java
Outdated
Show resolved
Hide resolved
NassimBtk
reviewed
Feb 18, 2025
metricshub-agent/src/main/java/org/sentrysoftware/metricshub/cli/HttpCli.java
Outdated
Show resolved
Hide resolved
* Remplacer le label de `positionalMethod` par `method`. * Optimiser la méthode `resolveMethod()`. * Tester sur metricshub.
NassimBtk
approved these changes
Feb 18, 2025
NassimBtk
deleted the
feature/issue-582-simplify-the-options-required-in-httpcli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
positionalMethodandpositionalUrlwhich allow to create CLI requests without using--methodand--url.Tests
Use cases
1
2
3
4
5
6
7
8
9
10
11