This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
tweak: enhance delete confirm dialog #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaromm2
commented
Aug 6, 2021
Comment on lines
+1
to
+9
| .actions{ | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-around; | ||
| } | ||
|
|
||
| .form-field--full-width{ | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
Actually these are a bit redundant as we can use bootstrap utility classes flex-row justify-content-around and w-100 for this purpose
alvaromm2
commented
Aug 6, 2021
| @Component({ | ||
| selector: 'wt-confirm-delete-dialog', | ||
| templateUrl: './confirm-delete-dialog.component.html', | ||
| styleUrls: ['./confirm-delete-dialog.component.scss'] |
There was a problem hiding this comment.
Oh and I missed setting change detection to OnPush (I usually have it configured as the default strategy)
alvaromm2
commented
Aug 6, 2021
Comment on lines
+158
to
+159
| maxWidth: '90%', | ||
| width: '300px', |
There was a problem hiding this comment.
These could also be provided as default using the MAT_DIALOG_DEFAULT_OPTIONS DI token if needed & specified by the design system, allowing for less boilerplate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Angular Material's dialog to prompt user for entering workflow name & confirm delete action.