Convert coordinator/substrate/db to use create_db macro #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of pr #408.
SubstrateDb
was split intoBlockDb
,EventDb
,SessionDb
, andBatchDb
, some helper methods to convert to/from the expected type were removed as they're covered by the macro.Considerations
handled
was renamed tois_unhandled
. Calling code was largely in the formif !SubstrateDb::handled(...) { ... }
, removing the negation and changing the name helps align the code with the intent.handle_event
could be refactored into a simple set method, I noticed that the calling code often performs the necessary checks however I didn't feel comfortable making this change due to someasync
statements that could break the previous assertions.