PHP 8.4 - implicit nulls are deprecated #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbyte
force-pushed
the
fix-php-8.4-implicit-nulls
branch
3 times, most recently
from
976522f
to
d0edfa3
Compare
`MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead` `CacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead` Updated Github Actions workflow to include PHP 8.4 Fixes serbanghita#956 Replaces serbanghita#957
drbyte
force-pushed
the
fix-php-8.4-implicit-nulls
branch
from
d0edfa3
to
8033d6e
Compare
|
Note: phpstan hasn't yet fixed this same issue within their package. Fortunately it's backward compatible back to at least PHP 8.0, so all the tests are passing fine. |
|
Checking this asap, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use explicit nullable type.
MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used insteadCacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used insteadAlso updated Github Actions workflow to include PHP 8.4
Fixes #956
Replaces #957