Use Client Hints Sec-CH-UA-Mobile header to detect mobile #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digifa
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
i would approve this, even it is a partial fix for identifying mobile devices and does not separate between phones and tablets.
Generic identifying a tablet is more difficult as there are more indicators - next step should be to identify Tablets by known model name in Sec-CH-UA-Model Header.
|
@kevinkimball pushed your changes manually into production. Thank you! 👏 @digifa thanks for the review, I guess now we have to check every Client Hint specific header |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome now sends Client Hint headers and a frozen UA string in newer versions. See this post for a full explanation:
https://developer.chrome.com/docs/privacy-security/user-agent-client-hints
Sec-CH-UA-Mobilespecifically is a "low-entropy hint" which means it is sent with every request. See:https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Platform
This partially resolves the issue in #906 although I didn't do anything with tablet detection.