Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seq is homoegeneous not hereogeneous #47

Closed
wants to merge 2 commits into from

Conversation

tomprince
Copy link

The description suggests that a seq is homogenous.

@dtolnay
Copy link
Member

dtolnay commented Apr 21, 2017

I think this is correct as written. For example this heterogeneous sequence is fine:

let mut seq = serializer.serialize_seq(Some(3))?
seq.serialize_element("string")?;
seq.serialize_element(&true)?;
seq.serialize_element(&256)?;
seq.end()

Thanks anyway!

@dtolnay dtolnay closed this Apr 21, 2017
@tomprince
Copy link
Author

tomprince commented Apr 21, 2017

In that case, I think the following text, suggesting Vec<T> or BTreeMap<K, V> is at least misleading (since all the examples are homogeneous).

@dtolnay
Copy link
Member

dtolnay commented Apr 21, 2017

Fair enough! I filed #48 to follow up.

@serde-rs serde-rs locked and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants