Merge pull request #109 from seregazhuk/develop

Pins like fix

CHANGELOG.md

@@ -1,6 +1,11 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [3.2.3] - 2016-06-09
+### Fixes:
+ - Pins like/dislike
+ - Response error check
+
 ## [3.2.2] - 2016-06-05
 ### Updated:
  - Keywords provider

src/Api/Providers/Provider.php

@@ -64,7 +64,7 @@ protected function execPostRequest($requestOptions, $resourceUrl, $returnData =
             return $this->response->getData($response);
         }
 
-        return $this->response->checkResponse($response);
+        return $this->response->checkErrorInResponse($response);
     }
 
     /**

src/Api/Response.php

@@ -69,16 +69,6 @@ public function notEmpty($response)
         return !empty($this->getData($response));
     }
 
-    /**
-     * @param array $response
-     *
-     * @return bool
-     */
-    public function checkResponse($response)
-    {
-        return $this->notEmpty($response) && $this->checkErrorInResponse($response);
-    }
-
     /**
      * Check for error info in api response and save
      * it.
@@ -145,7 +135,7 @@ public function parseSearchResponse($response, $bookmarksUsed = true)
      */
     public function getPaginationData($response)
     {
-        if (!$this->checkResponse($response)) {
+        if (!$this->notEmpty($response) && !$this->checkErrorInResponse($response)) {
             return [];
         }
 

src/Contracts/ResponseInterface.php

@@ -52,15 +52,6 @@ public function getBookmarksFromResponse($response);
      */
     public function getPaginationData($res);
 
-    /**
-     * Checks if response is empty or has errors.
-     *
-     * @param $response
-     *
-     * @return mixed
-     */
-    public function checkResponse($response);
-
     /**
      * Parses Pinterest search API response for data and bookmarks
      * for next pagination page.

src/Helpers/UrlHelper.php

@@ -33,8 +33,8 @@ class UrlHelper
     const RESOURCE_REPIN = '/resource/RepinResource/create/';
     const RESOURCE_USER_FOLLOWERS = '/resource/UserFollowersResource/get/';
     const RESOURCE_DELETE_PIN = '/resource/PinResource/delete/';
-    const RESOURCE_LIKE_PIN = '/resource/PinLikeResource2/create/';
-    const RESOURCE_UNLIKE_PIN = '/resource/PinLikeResource2/delete/';
+    const RESOURCE_LIKE_PIN = '/resource/PinLikeResource/create/';
+    const RESOURCE_UNLIKE_PIN = '/resource/PinLikeResource/delete/';
     const RESOURCE_COMMENT_PIN = '/resource/PinCommentResource/create/';
     const RESOURCE_COMMENT_DELETE_PIN = '/resource/PinCommentResource/delete/';
     const RESOURCE_PIN_INFO = '/resource/PinResource/get/';

tests/ConversationsTest.php

@@ -30,7 +30,7 @@ public function sendMessage()
         $this->setResponse($response);        
         $this->assertTrue($this->provider->sendMessage($userId, $message));
 
-        $this->setResponse(null);
+        $this->setResponse($this->createErrorApiResponse());
         $this->assertFalse($this->provider->sendMessage($userId, $message));
     }
 
@@ -44,7 +44,7 @@ public function sendEmail()
         $this->setResponse($response);        
         $this->assertTrue($this->provider->sendEmail($email, $message));
 
-        $this->setResponse(null);
+        $this->setResponse($this->createErrorApiResponse());
         $this->assertFalse($this->provider->sendEmail($email, $message));
     }
 

tests/PinsTest.php

@@ -93,7 +93,7 @@ public function editPin()
         $this->setResponse($response);
         $this->assertNotFalse($this->provider->edit(1, 'new', 'changed'));
 
-        $this->setResponse(null);
+        $this->setResponse($this->createErrorApiResponse());
         $this->assertFalse($this->provider->edit(1, 'new', 'changed'));
     }
 
@@ -104,7 +104,7 @@ public function deletePin()
         $this->setResponse($response);
         $this->assertNotFalse($this->provider->delete(1));
 
-        $this->setResponse(null);
+        $this->setResponse($this->createErrorApiResponse());
         $this->assertFalse($this->provider->delete(1));
     }
 
@@ -115,7 +115,7 @@ public function getPinInfo()
         $this->setResponse($response);
         $this->assertNotNull($this->provider->info(1));
 
-        $this->setResponse(null);
+        $this->setResponse($this->createErrorApiResponse());
         $this->assertFalse($this->provider->info(1));
     }