Merge pull request #436 from seregazhuk/uploads-fix

Fix for uploads from non-ascii links
seregazhuk · Dec 29, 2018 · fadae22 · fadae22
2 parents f09128a + 9112543
commit fadae22
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,10 +1,12 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
-## v5.9.0 - 2018-11-25
+## v5.9.0 - 2018-12-29
 ### Added:
  - Support for Reach Pins. You can specify a title when creating/editing a pin.
  - Allow to specify a board section when create/edit Pins.
+### Fixed:
+ - Uploads from non-ascii links
 
 ## v5.8.2 - 2018-08-17
 ### Added:

diff --git a/src/Api/Providers/Pins.php b/src/Api/Providers/Pins.php
@@ -57,8 +57,8 @@ class Pins extends EntityProvider
      */
     public function create($imageUrl, $boardId, $description = '', $link = '', $title = '', $sectionId = null)
     {
-        // Upload image if first argument is not an url
-        if (!filter_var($imageUrl, FILTER_VALIDATE_URL)) {
+        // Upload image if first argument is a local file
+        if (file_exists($imageUrl)) {
             $imageUrl = $this->upload($imageUrl);
         }