Kata/collections/test #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith LinkedHashSet
…th Treeset that accepts a comparator
wakaleo
reviewed
Sep 21, 2016
| */ | ||
| public interface BookingStratgey { | ||
|
|
||
| public BookingConfirmation checkIn( Pet pet); |
There was a problem hiding this comment.
The "public" keyword on methods is not required for an interface.
|
|
||
| public BookingConfirmation checkIn(Pet pet) { | ||
| BookingStratgey bookingStrategy = BOOKING_STARTEGY.get(currentAvailability()); | ||
| return bookingStrategy.checkIn(pet); |
There was a problem hiding this comment.
Great use of the strategy pattern, well done!
|
|
||
| //WHEN | ||
| Pet fido = Pet.dog().named("Fido"); | ||
| BookingResponse response =aPetHotel.checkIn(fido); |
There was a problem hiding this comment.
Since the response is not the focus of this particular test, you could also simply write:
aPetHotel.checkIn(fido);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding pull request for the 2 hour coding exercise.