Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-ascii with ascii characters #144

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

Alan-Jowett
Copy link
Contributor

@Alan-Jowett Alan-Jowett commented Oct 28, 2024

This pull request includes a small change to the elfio/elf_types.hpp file. The change corrects a typographical error in the comment for the EM_BPF constant.

  • elfio/elf_types.hpp: Changed the comment for EM_BPF from "Linux BPF – in-kernel virtual machine" to "Linux BPF - in-kernel virtual machine" to replace the en dash with a hyphen.

The "en dash" is a non-ascii character sequence and it not portable across other code-pages, causing breaks when building with a Cantonese code page.

@Alan-Jowett Alan-Jowett changed the title Replace non-ansi with ansi characters Replace non-ascii with ascii characters Oct 28, 2024
@serge1 serge1 merged commit b13dc75 into serge1:main Oct 29, 2024
16 of 20 checks passed
@serge1
Copy link
Owner

serge1 commented Oct 29, 2024

Accepted and merged.

Thank you!
Serge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants