Add support for multiple value keys #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyt
requested changes
Apr 7, 2017
index.js
Outdated
| @@ -430,6 +430,11 @@ function make_bloodhound(dataset) { | |||
| var engine; | |||
|
|
|||
| if (need_bloodhound) { | |||
| // Supports multiple fields passed, deliniated by spaces | |||
| if (dataset.valueKey.indexOf(" ") !== -1) { | |||
There was a problem hiding this comment.
consider to use comma as delimiter
index.js
Outdated
| @@ -430,6 +430,11 @@ function make_bloodhound(dataset) { | |||
| var engine; | |||
|
|
|||
| if (need_bloodhound) { | |||
| // Supports multiple fields passed, deliniated by spaces | |||
| if (dataset.valueKey.indexOf(" ") !== -1) { | |||
There was a problem hiding this comment.
also lets avoid mutation of input argument performing this initialization in calling code
There was a problem hiding this comment.
Ok thanks, was just a quick initial thought as I'm working it into my own project. I'll update, and use your comma suggestion as I do.
janat08
pushed a commit
to janat08/meteor-typeahead
that referenced
this pull request
Apr 12, 2018
Minor change to the docs to log the object instead of assuming it is a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply splits the passed string for value keys on space deliniation to pass as bloodhound.tokenizer parameter.