ref homologate data structures V/V #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
commented
Aug 11, 2021
src/settings.rs
Outdated
| rename(deserialize = "sshOpts") | ||
| )] | ||
| #[merge(strategy = merge::vec::append)] | ||
| pub ssh_opts: Vec<String>, // TODO: figure out type casting |
There was a problem hiding this comment.
Here is where #116 comes into play. See: https://github.com/clap-rs/clap/blob/master/clap_derive/examples/keyvalue.rs#L29
blaggacao
changed the title
- preparation for a more view based data access
blaggacao
force-pushed
the
ref-homologate-data-structures
branch
from
c6c2f00 to
77e28b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built cumulatively on top of
four other PRs.
For confidence in review, only the fifth
commit is meant to be considered.
TargetdataThis PR finally culminantes based on the preparatory
PRs to homologate the internal data structures.
This will allow us (and newcomers to the codebase)
to more easied reason about the nature of certain
internal state.
TODO: assimilate #116
once merged.