iog master diff #126
Draft
iog master diff #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- preparation for a more view based data access
|
Hey, I just wanted to say big thank you for working on deploy-rs, and sorry to make you wait! Our team is currently quite busy with other stuff, we'll review your PRs as soon as we're able. ❤️ |
Also requires a newer version of Rust, so pull in fenix to get the latest rust release. Some code fixes were necessary after dependency update as well.
Frameworks are libraries used at runtime, so should be in buildInputs and not nativeBuildInputs. Closes serokell#132
- Announcing a revocation without doing one is confusing
- This affords better help rendering (at the very least)
- generic nixosconfig be known that are hydrated with a target-ip during runtime (e.g. from a remote source) - Example: auto scaling groups
Also, ensure we are setting `RUST_SRC_PATH` from the actual rust derivation in use in the shell.
- the previous debbugging messages where a bit inconsistent and not enough
- if the connection is fast, DO NOT substitute on target - if the connection is slow, DO substitute on target
- this will safe some rebuild cycles and half a megaton of CO2 over 6monts (ok, I made that last one up)
nrdxp
force-pushed
the
master
branch
5 times, most recently
from
24a3d8e to
e71808a
Compare
A lot of the time rollbacks are just causing a big headache
Just log the error instead of quiting the application.
Useful so that building the derivations still uses the nix config values set directly in the flake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stuff we need
This should help keep track of the stuff that we already depend on
and help triage what might be useful to upstream.