Use more complex activation wrapper and add workaround for deploy-rs#185 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgne2
force-pushed
the
fix/185
branch
6 times, most recently
from
6245ab9 to
ba35a6d
Compare
|
To make it more discoverable, these both fix it upstream: NixOS/nixpkgs#209829 NixOS/nixpkgs#210505 - extra investigation into other bootloader builders might also be a good idea. imo regardless of upstream fixes we should still do the more complex wrapper, but if all goes well upstream we can drop the workaround part of this patch. |
balsoft
approved these changes
Mar 6, 2023
|
@notgne2, may I ask you to squash and rebase your branch before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has to be a better way, but this should work around #185 for now, I've tested it on my own system and I am able to successfully boot with systemd-initrd for the first time. This could have been a smaller patch but I also wanted to change the way the
activatable-wrapping works to be be a little more sneaky and hopefully trip things up a little less.