Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parseEscape errors more informative #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make parseEscape errors more informative #37

wants to merge 2 commits into from

Conversation

lierdakil
Copy link
Contributor

Allow partial parses in 'parseEscapes', but use a greedy parser. Show
the character escape that failed to parse and input position in the
error message.

@lierdakil
Make parseEscape errors more informative
9128326 
Allow partial parses in 'parseEscapes', but use a greedy parser. Show
the character escape that failed to parse and input position in the
error message.
kirelagin
kirelagin reviewed Dec 29, 2021
View reviewed changes
Copy link
Contributor

@kirelagin kirelagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, but can you please add tests that exercise all the error conditions?

@lierdakil
Copy link
Contributor Author

The change looks good to me, but can you please add tests that exercise all the error conditions?

I've added a couple tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirelagin kirelagin kirelagin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lierdakil @kirelagin