[DMS-68] Deduplicate switch cases using or-patterns #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes in logic so far, just simple refactoring
Add `MapOps` class with the following signature:
public class MapOps<K>(compare : (K,K) -> O.Order) {
public func put<V>(rbMap : Map<K, V>, key : K, value : V) : Map<K, V>
public func fromIter<V>(i : I.Iter<(K,V)>) : Map<K, V>
public func replace<V>(rbMap : Map<K, V>, key : K, value : V) : (Map<K,V>, ?V)
public func mapFilter<V1, V2>(f : (K, V1) -> ?V2, rbMap : Map<K, V1>) : Map<K, V2>
public func get<V>(key : K, rbMap : Map<K, V>) : ?V
public func delete<V>(rbMap : Map<K, V>, key : K) : Map<K, V>
public func remove< V>(rbMap : Map<K, V>, key : K) : (Map<K,V>, ?V)
};
The other functionality provided as standalone functions, as they
don't require comparator:
public type Direction = { #fwd; #bwd };
public func iter<K, V>(rbMap : Map<K, V>, direction : Direction) : I.Iter<(K, V)>
public func entries<K, V>(m : Map<K, V>) : I.Iter<(K, V)>
public func keys<K, V>(m : Map<K, V>, direction : Direction) : I.Iter<K>
public func vals<K, V>(m : Map<K, V>, direction : Direction) : I.Iter<V>
public func map<K, V1, V2>(f : (K, V1) -> V2, rbMap : Map<K, V1>) : Map<K, V2>
public func size<K, V>(t : Map<K, V>) : Nat
public func foldLeft<Key, Value, Accum>(
combine : (Key, Value, Accum) -> Accum,
base : Accum,
rbMap : Map<Key, Value>
) : Accum
And foldRight with the same signature as foldLeft
The following functions are new for the API:
- MapOps.put, MapOps.delete
- MapOps.fromIter, entries, keys, vals
- MapOps.mapFilter, map
- foldLeft, foldRight
Problem: now order is not consistent within new module and with old modules as well. Solution: make the map argument always go first
In addition to tests this patch removes `direction` argument from `keys` and `values` function to keep them simple and provides a new function `Map.empty` to create a map without knowing its internal representation.
Specify keys order in iterators
This PR didn't touch folds and map as benchmark showed us that it performs worse.
|
Get: 1-2% slower |
GoPavel
added
experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In comparison with milestone-2
Map comparison
Persistent map API