Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPS-1458] Add haskell.nix wrapper for CI #137

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

Sereja313
Copy link
Member

Problem: Our CI template for libraries allows one to specify ghc-versions so that we can build a library in different configurations. Currently the only configurable thing is the GHC version. We also want to be able to build libraries with different stack.yaml files and stack resolvers.

Solution: Add a haskell.nix wrapper to the library CI capable of building a project with different GHC versions, stack.yaml files, and stack resolvers.

@Sereja313 Sereja313 requested a review from a team August 2, 2023 09:59
@karandit
Copy link
Contributor

karandit commented Aug 2, 2023

sorry, I looked at it, but I lack the proper competency

lib/haskell.nix Show resolved Hide resolved
lib/haskell.nix Outdated Show resolved Hide resolved
lib/haskell.nix Outdated Show resolved Hide resolved
lib/haskell.nix Outdated Show resolved Hide resolved
Copy link
Member

@rvem rvem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Problem: Our CI template for libraries allows one to specify
ghc-versions so that we can build a library in different
configurations. Currently the only configurable thing is the GHC
version. We also want to be able to build libraries with different
stack.yaml files and stack resolvers.

Solution: Add a haskell.nix wrapper to the library CI capable of
building a project with different GHC versions, stack.yaml files, and
stack resolvers.
@Sereja313 Sereja313 merged commit 042ae97 into master Aug 10, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the sereja/OPS-1458-ci-wrapper branch August 10, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants