Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add weeder check #156

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[Chore] Add weeder check #156

merged 1 commit into from
Sep 24, 2024

Conversation

Sereja313
Copy link
Member

Problem: We want to be able to check our Haskell applications for dead code. This can be done using weeder.

Solution: Add weeder check to our overlay.

overlay/default.nix Show resolved Hide resolved
overlay/default.nix Show resolved Hide resolved
flake.nix Outdated
@@ -19,6 +19,10 @@
url = "github:Kleidukos/get-tested/v0.1.6.0";
flake = false;
};
weeder-src = {
url = "github:ocharles/weeder";
flake = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, it is actually a flake :pled:
Sadly, it doesn't expose executable

@Sereja313 Sereja313 requested a review from rvem April 2, 2024 20:34
@gromakovsky
Copy link
Member

Sorry for late review, but recently there appeared https://github.com/NorfairKing/weeder-nix which is now mentioned in https://github.com/ocharles/weeder README. Can we use it to simplify the code written in this PR?

@gromakovsky
Copy link
Member

@Sereja313 or @rvem could you please look into it? ⬆️

@Sereja313
Copy link
Member Author

Sorry for late review, but recently there appeared https://github.com/NorfairKing/weeder-nix which is now mentioned in https://github.com/ocharles/weeder README. Can we use it to simplify the code written in this PR?

The current solution is based on the haskell.nix, which we already use for building and testing package, and weeder-nix uses the nixpkgs toolkit to generate hie files. So I'm guessing there may be inconsistencies when the package builds with haskell.nix, but it also requires some manual work to make it suitable for building with nixpkgs to get weeder-nix to work.
So I'm not sure if it's worth it

Problem: We want to be able to check our Haskell applications for dead
code. This can be done using weeder.

Solution: Add weeder check to our overlay.
@Sereja313 Sereja313 merged commit 34f3593 into master Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants