[#119] Support link blocks #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If a user types a message with a link, the link text will be ignored by the `MessageBlock` processor: For example, in the message below, `extractPieces` will return `["Hey let's meet at ", "tomorrow?"]`. ``` Hey, let's meet at [10:30](link to google calendar here) tomorrow? ``` Solution: Parse blocks of type `link`, and collate the link text with adjacent text-like blocks.
dcastro
force-pushed
the
diogo/#119-support-link-blocks
branch
from
73f9077
to
cabd88f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: If a user types a message with a link, the link text will be ignored by the
MessageBlockprocessor:For example, in the message below,
extractPieceswill return["Hey let's meet at ", "tomorrow?"].Solution: Parse blocks of type
link, and collate the link text with adjacent text-like blocks.Related issue(s)
Fixed #119
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Stylistic guide (mandatory)
✓ Release Checklist
package.yaml.with a summary of all user-facing changes.
vX.Y