[#108] Improve block support #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: right now, when find an emoji block in a message, we split the message in two. This means this message: ``` Hey, let's meet at 10:30 🕐 tomorrow? ``` Will be interpreted as two separate sentences, `["Hey, let's meet at 10:30", "tomorrow?"]`, and "tomorrow" won't be taken into account. Solution: skip over emoji blocks, and collate adjacent text-like blocks. This is now parsed as a single sentence `["Hey, let's meet at 10:30 tomorrow?"]`
dcastro
force-pushed
the
diogo/#108-improve-block-support
branch
from
bc3c5a7 to
4e57a2d
Compare
Problem: The example JSON in `justEverythingRaw` appears to have been aeson-decoded and then aeson-encoded, which means the object keys have been reordered alphabetically (that's what aeson does). However, this makes it harder to reconstruct this JSON if we ever need to. It's simpler to just paste the JSON we get directly from Slack's Web API. Solution: Paste the JSON exactly as returned by Slack's Web API.
Problem: The server reports warnings whenever it finds a message with a tag like `@user`. Since this occurs very often, it ends up flooding the logs. Solution: Don't report warnings for blocks of type `user`, `usergroup` and `broadcast`.
dcastro
force-pushed
the
diogo/#108-improve-block-support
branch
from
4e57a2d to
8160f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: right now, when find an emoji block in a message, we split the
message in two. This means this message:
Will be interpreted as two separate sentences,
["Hey, let's meet at 10:30", "tomorrow?"], and "tomorrow" won't be taken into account.Solution: skip over emoji blocks, and collate adjacent text-like blocks.
This is now parsed as a single sentence
["Hey, let's meet at 10:30 tomorrow?"]Problem: The server reports warnings whenever it finds a message with a
tag like
@user. Since this occurs very often, it ends up flooding thelogs.
Solution: Don't report warnings for blocks of type
user,usergroupand
broadcast.Related issue(s)
Fixed part of #108
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Stylistic guide (mandatory)
✓ Release Checklist
package.yaml.with a summary of all user-facing changes.
vX.Y