Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#108] Handle messages with link previews #122

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

dcastro
Copy link
Member

@dcastro dcastro commented Sep 8, 2023

Description

Whenever a user posts a message with a link, and Slack subsequently displays a preview of that URL, an event is sent to the server, and the server fails to parse it.

This PR fixes that and adds the MDMessageUrlUnfurl constructor.

Related issue(s)

Fixed part of #108

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:

Stylistic guide (mandatory)

✓ Release Checklist

  • I updated the version number in package.yaml.
  • (After merging) I created a new entry in the releases page,
    with a summary of all user-facing changes.
    • I made sure a tag was created using the format vX.Y

@dcastro dcastro merged commit 4b243ec into main Sep 8, 2023
3 checks passed
@dcastro dcastro deleted the diogo/#108-handle-url-unfurl branch September 8, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant