Remind contexts and apply to time refs #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriRomanowski
added a commit
that referenced
this pull request
Feb 24, 2023
Problem: Sometimes, context of a time reference can be spread over one sentence, several different sentences or even several different messages. Solution: Parse contexts alone, remind them and apply to context-free time references when encountered; track a context during thread evolution.
YuriRomanowski
force-pushed
the
YuriRomanowski/remind-contexts-and-apply-to-time-refs
branch
from
b390131
to
ec5c7ca
Compare
YuriRomanowski
force-pushed
the
YuriRomanowski/#79-add-support-for-hyphenated-intervals
branch
2 times, most recently
from
2dcf198
to
461920b
Compare
Problem: when a user writes "10am-11am UTC ...", context is not shared between times, and second time can be skipped because every time should go after a space. Solution: Parse time references that are grouped via hyphen, slash, "and", "or" sharing their context: date ref, location ref, am/pm.
YuriRomanowski
force-pushed
the
YuriRomanowski/#79-add-support-for-hyphenated-intervals
branch
from
461920b
to
148360b
Compare
YuriRomanowski
added a commit
that referenced
this pull request
Feb 24, 2023
Problem: Sometimes, context of a time reference can be spread over one sentence, several different sentences or even several different messages. Solution: Parse contexts alone, remind them and apply to context-free time references when encountered; track a context during thread evolution.
YuriRomanowski
force-pushed
the
YuriRomanowski/remind-contexts-and-apply-to-time-refs
branch
from
ec5c7ca
to
9d9bfde
Compare
YuriRomanowski
added a commit
that referenced
this pull request
Feb 24, 2023
Problem: Sometimes, context of a time reference can be spread over one sentence, several different sentences or even several different messages. Solution: Parse contexts alone, remind them and apply to context-free time references when encountered; track a context during thread evolution.
YuriRomanowski
force-pushed
the
YuriRomanowski/remind-contexts-and-apply-to-time-refs
branch
from
9d9bfde
to
e32b0bf
Compare
|
Looks much better 😅 |
YuriRomanowski
commented
Feb 24, 2023
| @@ -92,8 +92,12 @@ run opts = do | |||
| managed $ withTzCacheDefault defaultMessageInfoCachingTime | |||
| bsReportEntries <- | |||
| managed $ withTzCacheDefault cCacheReportDialog | |||
| -- auto-acknowledge received messages | |||
|
|
|||
| let defaultConversationStateCachingTime = hour 12 | |||
There was a problem hiding this comment.
This ideally should be in the config
YuriRomanowski
commented
Feb 24, 2023
| Cache.insert getMessageThreadId (msgId, newState) convStateCache | ||
| asks bsMessageCache >>= Cache.insert msgId (timeRefs, conversationState) | ||
|
|
||
| withNonEmptyTimeRefs timeRefs $ \neTimeRefs -> do |
There was a problem hiding this comment.
It seems that we will eventually rewrite this logic using some abstracting technique and write some tests, it gets a bit tricky as more internal state is kept.
Problem: Sometimes, context of a time reference can be spread over one sentence, several different sentences or even several different messages. Solution: Parse contexts alone, remind them and apply to context-free time references when encountered; track a context during thread evolution.
YuriRomanowski
force-pushed
the
YuriRomanowski/remind-contexts-and-apply-to-time-refs
branch
from
e32b0bf
to
aa1eb6f
Compare
dcastro
force-pushed
the
YuriRomanowski/#79-add-support-for-hyphenated-intervals
branch
2 times, most recently
from
e3cc9f3
to
fff943d
Compare
dcastro
force-pushed
the
YuriRomanowski/#79-add-support-for-hyphenated-intervals
branch
from
369fbef
to
4756b9b
Compare
Base automatically changed from
YuriRomanowski/#79-add-support-for-hyphenated-intervals
to
main
August 21, 2023 15:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Sometimes, context of a time reference can be spread over one sentence, several different sentences or even several different messages.
Solution: Parse contexts alone, remind them and apply to context-free time references when encountered; track a context during thread evolution.
Related issue(s)
Part of #16
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Stylistic guide (mandatory)