Fix 'Misdetected cycle between :cli-bot:shadowJar and :cli-bot:test'

serpro69 · May 29, 2024 · 20c85c5 · 20c85c5
1 parent bee9cb1
commit 20c85c5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/buildSrc/src/main/kotlin/faker-base-conventions.gradle.kts b/buildSrc/src/main/kotlin/faker-base-conventions.gradle.kts
@@ -79,7 +79,6 @@ tasks.withType<Jar> {
 tasks {
     getByName(integrationTest.name).dependsOn(test)
     jar { dependsOn(integrationTest) }
-    assemble { dependsOn(jar) }
 }
 
 tasks.withType<DokkaTask>().configureEach {

diff --git a/buildSrc/src/main/kotlin/faker-lib-conventions.gradle.kts b/buildSrc/src/main/kotlin/faker-lib-conventions.gradle.kts
@@ -82,5 +82,5 @@ publishing {
 
 tasks {
     getByName(shadowJar.name).dependsOn(jar)
-    assemble { dependsOn(shadowJar) }
+    build { dependsOn(shadowJar) }
 }
diff --git a/cli-bot/build.gradle.kts b/cli-bot/build.gradle.kts
@@ -74,7 +74,6 @@ val shadowJar by tasks.getting(ShadowJar::class) {
     // we also need to make sure ShadowJar task depend on core having been built
     dependsOn(":core:shadowJar")
     fakers.forEach { dependsOn(":faker:$it:shadowJar") }
-    dependsOn(tasks.test)
 }
 
 // dunno why, but gradle is complaining that 'startScripts' may run before dependencies have been built