fix: SC-799 Added capture warning when spans are not closed (#631)

serverless · Apr 12, 2023 · 16f9a8b · 16f9a8b
1 parent 0be88a5
commit 16f9a8b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/node/packages/sdk/index.js b/node/packages/sdk/index.js
@@ -110,7 +110,13 @@ serverlessSdk._initialize = (options = {}) => {
   return serverlessSdk;
 };
 
-serverlessSdk._createTraceSpan = (name, options = {}) => new TraceSpan(name, options);
+serverlessSdk._createTraceSpan = (name, options = {}) =>
+  new TraceSpan(
+    name,
+    Object.assign(options, {
+      _reportWarning: reportWarning,
+    })
+  );
 serverlessSdk._reportError = reportError;
 serverlessSdk._reportWarning = reportWarning;
 serverlessSdk._reportNotice = reportNotice;

diff --git a/node/packages/sdk/lib/trace-span.js b/node/packages/sdk/lib/trace-span.js
@@ -43,6 +43,7 @@ class TraceSpan {
         );
       }
     }
+    this._reportWarning = options._reportWarning;
     this.startTime = startTime || defaultStartTime;
     this.name = ensureSpanName(name);
 
@@ -85,6 +86,7 @@ class TraceSpan {
       new TraceSpan(immediateDescendants.shift(), {
         startTime: this.startTime,
         immediateDescendants,
+        _reportWarning: this._reportWarning,
       });
     }
   }
@@ -132,10 +134,10 @@ class TraceSpan {
         leftoverSpans.push(subSpan.close({ endTime: this.endTime }));
       }
       if (leftoverSpans.length) {
-        process.stderr.write(
+        const message =
           "Serverless SDK Warning: Following trace spans didn't end before end of " +
-            `lambda invocation: ${leftoverSpans.map(({ name }) => name).join(', ')}\n`
-        );
+          `lambda invocation: ${leftoverSpans.map(({ name }) => name).join(', ')}\n`;
+        this._reportWarning(message, 'SDK_SPAN_NOT_CLOSED');
       }
       asyncLocalStorage.enterWith(this);
     } else {