[Fix #461] oneOf options must inherit union class common part #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #461
This slightly change the generated code public API.
Properties in POJOs that contains both properties and oneOf are moved to a parent class which is inherited by the oneOf alternative classes. This is done that way because reading two nested classes from the same json node is pretty tricky and will move the complexity to the generated serializer/deserializer (reinventing Jackson essentially)
Just one example, previously we have
after this PR, we will have
and