Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unecessary lifetime in the Sum implementation #56

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Remove an unecessary lifetime in the Sum implementation #56

merged 1 commit into from
Feb 23, 2024

Conversation

mrobinson
Copy link
Member

No description provided.

@mrobinson mrobinson mentioned this pull request Feb 23, 2024
Merged
Loirooriol
Loirooriol approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy would have caught that. Should we consider adding it as a CI check?

@mrobinson
Copy link
Member Author

Clippy would have caught that. Should we consider adding it as a CI check?

Sure, that makes sense to me.

@mrobinson mrobinson added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 228cf8d Feb 23, 2024
2 checks passed
@Loirooriol Loirooriol deleted the remove-needless-lifetime branch December 12, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loirooriol Loirooriol Loirooriol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrobinson @Loirooriol