Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on wrongly closed elements #447

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

vporton
Copy link

@vporton vporton commented Jul 25, 2021

html5ever (HTML in quirks mode specifically) was crashing on superfluous closing tags (I don't provide a test case, but that was a case).

This PR is a WIP (You may choose to accept this PR now or wait until it is tested or reviewed more.) that attempts to fix that bug. Need to add tests to ensure my code really fixed the bug.

This PR introduces new feature api_v2 to be used with new code. Enabling the feature makes the library incompatible with old code.

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #461) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants