-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update html5lib-tests #460
Conversation
What makes this a WIP? |
Hmm, in the sense that it's not mergeable as-is. I hadn't planned on working it for now though |
eh, I'm working on this now.
that's all there is to tokenizer tests, haven't looked at treebuilder tests yet. That said I am not really familiar with how treebuilding is done in the spec, so this could take quite a while. |
Good question about error codes. I suspect a decent way to handle that would be to make an actual error enum that gets passed to emit_error, and then make the html5lib test harness map those error variants to the codes that the html5lib tests expect. That being said, I'm inclined to file an issue about that and ignore specific error content for right now. |
input where it matters (JSON-escaped): "<!DOCTYPE0\r\nPUBLIC'"
corresponding changes in HTML spec are: whatwg/html@f690ad9 and follow-up discussion at whatwg/html#6439
@jdm all tests are fixed. can you take a look? |
@mrobinson Can you take a look maybe? |
Follow-up items:
I'm also fuzzing this branch continuously against https://github.com/untitaker/html5gum using
FUZZ_HTML5EVER=1
to find more bugs, but they only cover the tokenizer. Some bugfixes have been made and corresponding regression tests added in aregression.test
file.Fixes #459.