Implement declarative shadow DOM #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvatrong111
force-pushed
the
declarative-shadow-dom
branch
from
afb0305 to
01cef16
Compare
longvatrong111
force-pushed
the
declarative-shadow-dom
branch
from
01cef16 to
e22a6a0
Compare
5 tasks
simonwuelker
approved these changes
Jan 13, 2025
xiaochengh
reviewed
Jan 16, 2025
| // template start tag's shadowrootmode is not in the none state | ||
| let is_shadow_root_mode = tag.attrs.iter().any(|attr| { | ||
| attr.name.local == local_name!("shadowrootmode") | ||
| && (attr.value.to_string() == String::from("open") || attr.value.to_string() == String::from("close")) |
There was a problem hiding this comment.
Can we compare attribute values without creating String objects (which requires memory allocation)?
There was a problem hiding this comment.
You're right, we can avoid String creation in both sides like this:
attr.value.as_ref() == "open" || attr.value.as_ref() == "close"
I'll update with other missing parts of this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement declarative shadow dom (DSD) since it is necessary for several minor issues on Servo (for example: servo/servo#34746, servo/servo#34745)
Design doc (WIP):
Declarative Shadow DOM for Servo
This PR implements DSD creation.