Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "full" feature for syn #570

Closed
wants to merge 1 commit into from

Conversation

simonwuelker
Copy link
Contributor

Fixes the build issue brought up in #567 (comment)

@simonwuelker
Copy link
Contributor Author

I also ran cargo fmt to make CI pass

@simonwuelker simonwuelker force-pushed the all-the-syn branch 2 times, most recently from 9c2e97d to 31866e3 Compare January 21, 2025 22:55
@simonwuelker
Copy link
Contributor Author

Opened #571 instead to fix CI

This feature was previously required to compile,
but not specified. That worked because some other
dependency enabled it, but we must not rely on that.

Signed-off-by: Simon Wülker <[email protected]>
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@simonwuelker
Copy link
Contributor Author

Closing so this can land together with #571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants