Use Arc::get_mut instead of Arc::strong_count == 1

Arc::strong_count doesn't come with memory ordering guarantees. As such it should be possible to destory the context multiple times with the previous version of this check. See rust-lang/rust#117485 Signed-off-by: Greg Morenz <[email protected]>
servo · Mar 2, 2025 · 1c80d80 · 1c80d80
1 parent 87cabf4
commit 1c80d80
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/mozjs/src/rust.rs b/mozjs/src/rust.rs
@@ -431,9 +431,8 @@ impl Runtime {
 impl Drop for Runtime {
     fn drop(&mut self) {
         self.thread_safe_handle.write().unwrap().take();
-        assert_eq!(
-            Arc::strong_count(&self.outstanding_children),
-            1,
+        assert!(
+            Arc::get_mut(&mut self.outstanding_children).is_some(),
             "This runtime still has live children."
         );
         unsafe {