This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Redirect http://build.servo.org/ to HTTPS #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, please merge! ^^ #913 was ignored, so I closed it in a moment of weakness. xD Your change only affects command line clients as web browsers already enforce HTTPS since servo.org was added to the HSTS preload list (bug 1482947). |
|
r? @jdm |
|
iirc last time I made this change I broke our buildbot CI completely. This will need to wait until I see convincing evidence that that won't happen again. |
|
In particular, I believe that there are some python-based HTTP requests for build.servo.org that see a 301 response and raise an exception. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested, but matches what https://ssl-config.mozilla.org/ suggests. (This could be a good time to apply other suggestions from there too.)
This change is