Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo Redesign #202

Merged
merged 35 commits into from
Feb 3, 2025
Merged

Servo Redesign #202

merged 35 commits into from
Feb 3, 2025

Conversation

ststimac
Copy link
Collaborator

Initial re-design of servo.org. This re-design aims to make the site more modern and educational about Servo as a project and its many features.

@ststimac ststimac requested a review from mrego January 29, 2025 18:34
Copy link

Preview link: https://servo.org/servo-redesign/

@nicoburns
Copy link
Contributor

A few styling issues on 1512x982 sized screen (14 inch MBP):

Screenshot doesn't fit within height, even though it would still be a very reasonable size if it was constrained to fit

Screenshot 2025-01-30 at 13 14 18

Blog post listing looks a bit weird only taking up half the screen. Perhaps we should consider putting some other content alongside the post listing on larger screens? Or just making the box hug the contents?

Screenshot 2025-01-30 at 13 15 56

css/style.css Outdated Show resolved Hide resolved
.DS_Store Outdated Show resolved Hide resolved
Copy link

Preview link: https://servo.org/servo-redesign/

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
Copy link

Preview link: https://servo.org/servo-redesign/

Signed-off-by: Manuel Rego <[email protected]>
Copy link

Preview link: https://servo.org/servo-redesign/

Copy link
Member

@mrego mrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks great, thanks!

Left a couple of minor issues.

_includes/header.html Show resolved Hide resolved
css/style.css.map Outdated Show resolved Hide resolved
@sagudev
Copy link
Member

sagudev commented Jan 30, 2025

It would be nice to keep support for dark theme.

css/style.css Outdated Show resolved Hide resolved
@mrego
Copy link
Member

mrego commented Jan 30, 2025

It would be nice to keep support for dark theme.

The current site only has dark theme, the new design uses a light one. But we have plans to add dark theme support to have both options. Do you think this is a blocker or can be done in a follow-up task?

@sagudev
Copy link
Member

sagudev commented Jan 30, 2025

It would be nice to keep support for dark theme.

The current site only has dark theme, the new design uses a light one. But we have plans to add dark theme support to have both options. Do you think this is a blocker or can be done in a follow-up task?

It's not blocking.

@ststimac
Copy link
Collaborator Author

It would be nice to keep support for dark theme.

The current site only has dark theme, the new design uses a light one. But we have plans to add dark theme support to have both options. Do you think this is a blocker or can be done in a follow-up task?

It's not blocking.

I do have dark mode on the to do list. I can make that a goal for February as I think many people will want that option.

Copy link

Preview link: https://servo.org/servo-redesign/

@mrego
Copy link
Member

mrego commented Jan 30, 2025

It would be nice to keep support for dark theme.

The current site only has dark theme, the new design uses a light one. But we have plans to add dark theme support to have both options. Do you think this is a blocker or can be done in a follow-up task?

It's not blocking.

I do have dark mode on the to do list. I can make that a goal for February as I think many people will want that option.

Created an issue to track that: #206

Copy link

Preview link: https://servo.org/servo-redesign/

_includes/hero.html Outdated Show resolved Hide resolved
.eleventy.js Outdated Show resolved Hide resolved
Copy link

Preview link: https://servo.org/servo-redesign/

Copy link

Preview link: https://servo.org/servo-redesign/

Copy link

Preview link: https://servo.org/servo-redesign/

Copy link

Preview link: https://servo.org/servo-redesign/

@jschwe
Copy link
Member

jschwe commented Jan 31, 2025

Screenshot_20250131_102530_Firefox.jpg

I'm not sure how to describe this, but I feel like the first impression of mobile website main page is a bit too much "in my face". The font size is certainly much larger than before. I'm also not sure I like the font here, it feels hard to read. But that might also be related to the font size, because I don't mind the smaller text in the sections below.

@jschwe
Copy link
Member

jschwe commented Jan 31, 2025

https://servo.org/servo-redesign/download/

On the old download page the commands / errors are in a different color, which makes them stand out more. Could we get that back, or something similar to the markdown backtick styling on github?

@mrego
Copy link
Member

mrego commented Jan 31, 2025

https://servo.org/servo-redesign/download/

On the old download page the commands / errors are in a different color, which makes them stand out more. Could we get that back, or something similar to the markdown backtick styling on github?

Adding some style for code elements seems indeed useful, as we use it also a lot in the blog posts (check the --pref layout.grid.enabled in the first paragraph of https://servo.org/servo-redesign/blog/2024/12/09/this-month-in-servo/ ).

Copy link

Preview link: https://servo.org/servo-redesign/

Copy link

Preview link: https://servo.org/servo-redesign/

Copy link

Preview link: https://servo.org/servo-redesign/

@mrego
Copy link
Member

mrego commented Jan 31, 2025

Issues mentioned have been addressed. On mobile now text is smaller, text in downloads have it's own style and blogs section uses the whole width.

It looks things are ready, we plan to release the new design on Monday. Then we'll keep iterating and improving things on it.

Copy link

github-actions bot commented Feb 1, 2025

Preview link: https://servo.org/servo-redesign/

assets/css/style.css.liquid Outdated Show resolved Hide resolved
assets/css/style.css.liquid Show resolved Hide resolved
Copy link

github-actions bot commented Feb 3, 2025

Preview link: https://servo.org/servo-redesign/

@mrego mrego merged commit 194d48e into main Feb 3, 2025
2 checks passed
@mrego mrego deleted the servo-redesign branch February 3, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants