-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servo Redesign #202
Servo Redesign #202
Conversation
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Signed-off-by: Manuel Rego <[email protected]>
Preview link: https://servo.org/servo-redesign/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks great, thanks!
Left a couple of minor issues.
It would be nice to keep support for dark theme. |
The current site only has dark theme, the new design uses a light one. But we have plans to add dark theme support to have both options. Do you think this is a blocker or can be done in a follow-up task? |
It's not blocking. |
I do have dark mode on the to do list. I can make that a goal for February as I think many people will want that option. |
Preview link: https://servo.org/servo-redesign/ |
Created an issue to track that: #206 |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
I'm not sure how to describe this, but I feel like the first impression of mobile website main page is a bit too much "in my face". The font size is certainly much larger than before. I'm also not sure I like the font here, it feels hard to read. But that might also be related to the font size, because I don't mind the smaller text in the sections below. |
https://servo.org/servo-redesign/download/ On the old download page the commands / errors are in a different color, which makes them stand out more. Could we get that back, or something similar to the |
Adding some style for |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Issues mentioned have been addressed. On mobile now text is smaller, text in downloads have it's own style and blogs section uses the whole width. It looks things are ready, we plan to release the new design on Monday. Then we'll keep iterating and improving things on it. |
Preview link: https://servo.org/servo-redesign/ |
Preview link: https://servo.org/servo-redesign/ |
Initial re-design of servo.org. This re-design aims to make the site more modern and educational about Servo as a project and its many features.