feat: respect connected components for invalidation + full voxel graph support #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method will stay within the given component and may even be faster for certain situations (slower for others).
william-silversmith
added
feature
william-silversmith
added
the
redesign
roll_invalidation_ball_inside_component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the invalidation method from
roll_invalidation_cubetoroll_invalidation_ball_inside_component, this has several consequences.roll_invalidation_ball_inside_componentis...In all, it represents a step up in skeleton quality at the moderate expense of speed.
The other change is we now use
cc3d.color_connectivity_graphwhen a voxel graph is provided rather thancc3d.connected_components.In all, this provides full support for connectivity graph based skeletonization, which enables the accurate processing of volumes containing a "self-touch" (autapse).
Example results
An autapse visualized as a mesh:
Using PyChunkGraph information to create a voxel connectivity graph, processed with this PR:
Using the old method:
Performance characterization of a 5123 task (black) this PR (blue) old method without voxel graph:
