Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Empty staff list shows student's empty state #232 #233

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

hieungo89
Copy link
Contributor

@hieungo89 hieungo89 commented Nov 3, 2023

Referencing issue #232. I adjusted the specification of the empty state so Staff page shouldn't be affected by Student's list empty state anymore.

Before:
Screenshot 2023-11-03 at 10 11 17 AM

After:
Screenshot 2023-11-03 at 10 09 31 AM

@hieungo89 hieungo89 self-assigned this Nov 3, 2023
@hieungo89 hieungo89 linked an issue Nov 3, 2023 that may be closed by this pull request
Copy link
Contributor

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we edit the copy for the empty staff state instead?

@hieungo89
Copy link
Contributor Author

should we edit the copy for the empty staff state instead?

Niko confirmed that there won't be an empty staff state since the staff page will always have at least the current signed-in staff and never be empty.

Copy link
Contributor

@tessathornberry tessathornberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Hieu! Nice work! Maybe we can make a separate issue to add the user to the staff list, too! What do you think?

@hieungo89
Copy link
Contributor Author

Looks great, Hieu! Nice work! Maybe we can make a separate issue to add the user to the staff list, too! What do you think?

I'm planning to work on that next. When staff sign in for the first time, their name is automatically added to the staff list so the list won't be empty.

@hieungo89 hieungo89 merged commit 3aa00f0 into main Nov 8, 2023
@hieungo89 hieungo89 deleted the emptyStateStaff branch November 8, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Empty staff list shows student's empty state [ENG]
3 participants