don't add totals factor level if already present (#531)

fix #529

NEWS.md

@@ -1,7 +1,8 @@
 # janitor 2.2.0.9000 - unreleased development version
 
-No changes yet.
+## Bug fixes
 
+* `adorn_totals("row")` now succeeds if the new `name` of the totals row is already a factor level of the input data.frame (#529, thanks @egozoglu for reporting).
 
 # janitor 2.2.0 (2023-02-02)
 

R/adorn_totals.R

@@ -134,7 +134,9 @@ adorn_totals <- function(dat, where = "row", fill = "-", na.rm = TRUE, name = "T
       }
       dat[(nrow(dat) + 1), ] <- col_totals[1, ] # insert totals_col as last row in dat
       if(factor_input) { # restore factor/ordered info, #494
-        dat[[1]] <- factor(dat[[1]], levels = c(levels(col1_backup), name[1]), ordered = is.ordered(col1_backup))
+        dat[[1]] <- factor(dat[[1]],
+                           levels = c(setdiff(levels(col1_backup), name[1]), name[1]), # don't add if level is present
+                           ordered = is.ordered(col1_backup))
       }
     }
 

tests/testthat/test-adorn-totals.R

@@ -570,3 +570,13 @@ test_that("order is maintained when first column is a factor, #494", {
     "factor"
   )
 })
+
+test_that("if factor level already present, adorn_totals() still works, #529", {
+  factor_present <- mtcars %>%
+    tabyl(am, cyl)
+    factor_present$am <- factor(factor_present$am, levels = c("0", "1", "Total"))
+    expect_equal(
+      levels(adorn_totals(factor_present, "row")$am),
+      c("0", "1", "Total")
+    )
+})