52 about meet the team #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Geist font. Sans was added to body tag as it is default font. To use mono simply add className"font-GeistMono" to elements class to overide.
Works for now but should revise naming convention and sizes for mobile at a later time
class attached to main should be added to the styling branch at some point as a default way to have consistent margins.
Navbar is done but could benefit from an accessibility review at some point (medium priority) i.e. semantics and implementation of aria attributes (also I don't think its the right colour, I couldn't find the overlay colour in variables). The Navbar, radial gradient, and content wrapper styles were all added to the layout.tsx for consistency across pages. The content wrapper should be reviewed. The margin top applied to it is due to the navbar being fixed and as a result it is not in the regular document flow so we need something to push body content below the nav. @christinaraganit you might have a better approach to this. Also moved the styleguide page to its own directory so it doesn't conflict with the default landing page when we merge branches. footer was changed to self closing tag as react documentation says that you only need to use a closing tag if your component has children. My bad for long commit.
Mobile breakpoint for the RoleButtons still needs to be addressed (probably dropdown). Team members data is placeholder but I just received real data for team members, will work on adding that next
remember to add photo paths later
testing overflow scrolling too.
michael tran is missing .
fixed weird scrolling issues when changing team button
fixed some issues with local storage being declared outside the use effect.
added error check to fallback onto placeholder image for team members without photo.
✅ Deploy Preview for sfusurgedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@MichaelDresler please pull the current changes in the develop branch to your source branch, fix any merge conflicts, and then push the merge back onto your source branch |
|
@ChrisFong604 done! |
…surge_website into 52-about-meet-the-team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implemented the "meet the team" section of the landing page.
This includes:
buttons for choosing teams
team member cards + pictures
Issue ticket number and link
#52
Testing Steps
checkout to 52-about-meet-the-team
run pnpm install to update dependencies
run the development server (npm run dev).