Skip to content

Commit

Permalink
Fix [Gradle GWT compilation breakage](google#7134).
Browse files Browse the repository at this point in the history
Fixes google#7134

(tested using the sscce.zip from that issue, adding `mavenLocal()` to the top of its `repositories` and updating `guava-gwt` to `HEAD-jre-SNAPSHOT`)

RELNOTES=Fixed [Gradle GWT compilation breakage](google#7134).
PiperOrigin-RevId: 623826917
  • Loading branch information
cpovirk authored and Google Java Core Libraries committed Apr 11, 2024
1 parent dad0c59 commit 858caf4
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions guava-gwt/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,16 @@
<artifactId>guava</artifactId>
<version>${project.version}</version>
</dependency>
<!-- We redeclare the j2objc-annotations dependency from `guava`: Our Gradle
Module Metadata hides the dependency declared in `guava` from runtime
configurations downstream, and GWT uses the runtime configuration for
its builds. Thus, GWT doesn't get j2objc-annotations transitively, in
contrast to the other deps of `guava`, which it does get transitively.
(Arguably we should redeclare *all* the `guava` deps here.) -->
<dependency>
<groupId>com.google.j2objc</groupId>
<artifactId>j2objc-annotations</artifactId>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava-testlib</artifactId>
Expand Down

0 comments on commit 858caf4

Please sign in to comment.