-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devops improvement: Don't add command warning to standard output. #150
base: main
Are you sure you want to change the base?
Conversation
* fix: support drupal 11 * fix: improve code * fix: default installation * fix: update mariadb version to 10.6 * fix: update ddev-gitpod image (latest ddev version) * fix: lazygit binaries * fix: remove legacy settings from gitpod.yml * fix: use DP_CORE_VERSION when there's no issue_fork * fix: reorganize scripts order * Update .gitpod/drupal/drupalpod-setup/ddev_setup.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Allows fallback setup when DrupalPod is called with no DP_PROJECT_TYPE. That is the case when DrupalPod is called without using the browser extension.
It can mess up the expected output.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
WalkthroughThe changes involve modifying several shell script templates within the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- .gitpod/utils/script-templates/ddev-composer.template.sh (1 hunks)
- .gitpod/utils/script-templates/ddev-drush.template.sh (1 hunks)
- .gitpod/utils/script-templates/ddev-node.template.sh (1 hunks)
- .gitpod/utils/script-templates/ddev-npx.template.sh (1 hunks)
- .gitpod/utils/script-templates/ddev-nvm.template.sh (1 hunks)
- .gitpod/utils/script-templates/ddev-php.template.sh (1 hunks)
- .gitpod/utils/script-templates/ddev-yarn.template.sh (1 hunks)
Files skipped from review due to trivial changes (7)
- .gitpod/utils/script-templates/ddev-composer.template.sh
- .gitpod/utils/script-templates/ddev-drush.template.sh
- .gitpod/utils/script-templates/ddev-node.template.sh
- .gitpod/utils/script-templates/ddev-npx.template.sh
- .gitpod/utils/script-templates/ddev-nvm.template.sh
- .gitpod/utils/script-templates/ddev-php.template.sh
- .gitpod/utils/script-templates/ddev-yarn.template.sh
The Problem/Issue/Bug
When trying to run certain scripts, the warning added to the output is added directly to the standard output, and messes up the expected output.
How this PR Solves The Problem
It adds the notice to the standard output stream instead.
Ideally this notice should be behind an environment variable.
Manual Testing Instructions
Related Issue Link(s)
Release/Deployment notes
Summary by CodeRabbit