Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: don't attempt to push docker image from forks #2043

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

nodiscc
Copy link
Member

@nodiscc nodiscc commented Nov 23, 2023

  • only push the docker image to the ghcr registry when on the original shaarli/Shaarli fork
  • only run trivy docker image scans on the original shaarli/Shaarli fork
  • prevents 'Username and password required' errors when committing to forks which do not have the required CI secrets (registry username/password) set

@nodiscc nodiscc added the tools developer tools label Nov 23, 2023
@nodiscc nodiscc added this to the 0.14.0 milestone Nov 23, 2023
@nodiscc nodiscc self-assigned this Dec 3, 2023
- only push the docker image to the ghcr registry when on the original shaarli/Shaarli fork
- only run trivy docker image scans on the original shaarli/Shaarli fork
- prevents 'Username and password required' errors when committing to forks which do not have the required CI secrets (registry username/password) set
@nodiscc nodiscc merged commit 1d20124 into shaarli:master Dec 5, 2023
8 checks passed
@nodiscc nodiscc deleted the docker-push-only-on-origin branch December 5, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools developer tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant