Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding third party plugins clickcounter and targetblank #2063

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

waschinski
Copy link

No description provided.

@nodiscc nodiscc added plugin bells and whistles documentation labels Jan 12, 2024
Copy link
Member

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Should probably mention in the README of the clickcounter plugin, that the counter is only visible when logged in (at least it doesn't display for me on the demo site)

@waschinski
Copy link
Author

waschinski commented Jan 12, 2024

It actually should display even when not logged in, but I just recently reset the counters and probably nobody has clicked any links yet. ;)

Oh, and it will only show once the page has been reloaded.

@nodiscc nodiscc merged commit 8cdbda7 into shaarli:master Jan 15, 2024
8 checks passed
@waschinski waschinski deleted the patch-1 branch January 16, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation plugin bells and whistles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants