doc: server configuration: allow accessing and caching SVG assets #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Feb 17, 2024
- access to .svg files must be allowed in apache configuration - ref. shaarli/Shaarli#2074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some themes (e.g. https://github.com/RolandTi/shaarli-stack) use SVG assets for example to provide the favicon. The web server configuration example provided in Shaarli's documentation does not allow accessing
.svgfiles (a HTTP 403 error is returned).This Pull Request fixes it by allowing access to
.svgfiles in the example configuration for Apache and Nginx.Even though no SVG files are used in the default template, I think there are no real security concerns allowing them by default. The alternative is to mention in the documentation of those themes, that the virtualhost configuration file should be edited (not very user-friendly)
/cc @RolandTi