Skip to content

Commit

Permalink
Remove RUNPATH from executable
Browse files Browse the repository at this point in the history
Change release-linux workflow to build a release version
Add release-windows workflow to upload binary
  • Loading branch information
kaizhangNV committed Feb 12, 2024
1 parent 9726008 commit 97bd063
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ jobs:
id: build
run: |
echo "starting to build..."
cmake --build build/linux-gcc
cmake --build build/linux-gcc --config Release
export TAG_NAME=`git describe --tags`
export TAG=${TAG_NAME#v}
echo "tag:$TAG"
export OS_NAME=linux
export ARCH_NAME=`uname -p`
export FALCOR_PERF_TEST_PACKAGE=falcor_perf_test-${TAG}-${OS_NAME}-${ARCH_NAME}.zip
echo "creating zip at ${FALCOR_PERF_TEST_PACKAGE}"
zip -r ${FALCOR_PERF_TEST_PACKAGE} build/linux-gcc/bin/Debug/*
zip -r ${FALCOR_PERF_TEST_PACKAGE} build/linux-gcc/bin/Release/*
echo "FALCOR_PERF_TEST_PACKAGE=${FALCOR_PERF_TEST_PACKAGE}" >> $GITHUB_OUTPUT
- name: Upload Assert
uses: softprops/action-gh-release@v1
Expand Down
40 changes: 40 additions & 0 deletions .github/workflows/release-windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: release-win64

on:
push:
# Sequence of patterns matched against refs/tags
tags:
- 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10

jobs:
build:

runs-on: windows-latest

steps:
- uses: actions/checkout@v3

- name: Setup Ninja
uses: ashutoshvarma/setup-ninja@master
with:
# ninja version to download. Default: 1.10.0
version: 1.10.0

- name: configure
run: cmake --preset windows-ninja-msvc
- name: make
id: build
run: |
echo "build app"
cmake --build build/windows-ninja-msvc --config Release
$tagName = & git describe --tags
$binArchive = "falcor_perf_test-$tagName-win-64.zip"
echo "package name=$binArchive"
echo "FALCOR_PERF_TEST_PACKAGE=$binArchive" >> $env:GITHUB_OUTPUT
7z a "$binArchive" build/windows-ninja-msvc/bin/Release/*
- name: UploadBinary
uses: softprops/action-gh-release@v1
with:
files: |
${{ steps.build.outputs.FALCOR_PERF_TEST_PACKAGE }}
2 changes: 1 addition & 1 deletion source/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,4 @@ target_link_libraries(falcor_perftest
set_target_properties(falcor_perftest PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${FALCOR_RUNTIME_OUTPUT_DIRECTORY}
LIBRARY_OUTPUT_DIRECTORY ${FALCOR_LIBRARY_OUTPUT_DIRECTORY}
)
SKIP_BUILD_RPATH TRUE)

0 comments on commit 97bd063

Please sign in to comment.