[deadbeef] Remove dead code

[alejandro-colomar]

One of the benefits of rewriting a lot of code, is finding dead code that can be removed. :-)

Cc: @thesamesam

---

Revisions:

v2

• Delete another round of dead code.

$ git range-diff master gh/deadbeef deadbeef 
1:  28a46878 = 1:  28a46878 lib/, src/, doc/: Remove dead code
2:  5064c6b4 = 2:  5064c6b4 lib/pwauth.*: PW_{ADD,CHANGE,DELETE,FTP,REXEC}: Remove dead code
-:  -------- > 3:  17e7da68 lib/, src/, doc/: Remove pw_auth()'s  as dead code

v2b

• tfix in commit message

$ git range-diff master gh/deadbeef deadbeef 
1:  28a46878 = 1:  28a46878 lib/, src/, doc/: Remove dead code
2:  5064c6b4 = 2:  5064c6b4 lib/pwauth.*: PW_{ADD,CHANGE,DELETE,FTP,REXEC}: Remove dead code
3:  17e7da68 ! 3:  a66b4a9c lib/, src/, doc/: Remove pw_auth()'s  as dead code
    @@ Metadata
     Author: Alejandro Colomar <[email protected]>
     
      ## Commit message ##
    -    lib/, src/, doc/: Remove pw_auth()'s  as dead code
    +    lib/, src/, doc/: Remove pw_auth()'s $3 as dead code
     
         We don't read the parameter at all.  Remove it.
     

[thesamesam]

Nice!

[alejandro-colomar]

Nice!

Thanks!

I've taken that as a Reviewed-by. ;)

Cheers,
Alex

$ git range-diff master gh/deadbeef deadbeef 
1:  e938d475 ! 1:  28a46878 lib/, src/, doc/: Remove dead code
    @@ Commit message
         parameter.  Instead, set a local variable to NULL at function entry, and
         remove code that never runs (conditional on $4 != NULL).
     
    +    Reviewed-by: Sam James <[email protected]>
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## doc/HOWTO ##
2:  76bf1c3f ! 2:  5064c6b4 lib/pwauth.*: PW_{ADD,CHANGE,DELETE,FTP,REXEC}: Remove dead code
    @@ Commit message
     
         These values aren't being set anywhere.
     
    +    Reviewed-by: Sam James <[email protected]>
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/pwauth.c ##