configure.ac, src/Makefile.am: Follow GNU coding standards regarding directory variables

[alejandro-colomar]

Closes: #1229
Reported-by: @zeha
Cc: @thesamesam

---

Is this okay?

---

Revisions:

v2

• Remove definitions of $prefix and $exec_prefix. [@thesamesam ]

$ git range-diff master gh/ep ep 
1:  8840d0e3 ! 1:  6f4e5d61 configure.ac, src/Makefile.am: Follow GNU coding standards regarding directory variables
    @@ Metadata
      ## Commit message ##
         configure.ac, src/Makefile.am: Follow GNU coding standards regarding directory variables
     
    +    According to Sam, if we just remove the definitions, autotools will
    +    provide the right values.
    +
    +    Note that this changes the default from /usr to /usr/local, which is the
    +    right value according to the GNU conding standards (and also what the
    +    BSDs prefer, according to one conversation I had with Ingo Schwarze from
    +    OpenBSD).
    +
         Closes: <https://github.com/shadow-maint/shadow/issues/1229>
    +    Link: <https://www.gnu.org/software/autoconf/manual/autoconf-2.72/html_node/Default-Prefix.html>
         Reported-by: Chris Hofstaedtler <[email protected]>
         Cc: Sam James <[email protected]>
         Signed-off-by: Alejandro Colomar <[email protected]>
    @@ src/Makefile.am
      
     -ubindir = ${prefix}/bin
     -usbindir = ${prefix}/sbin
    -+prefix = /usr/local
    -+exec_prefix = ${prefix}
     +ubindir = ${exec_prefix}/bin
     +usbindir = ${exec_prefix}/sbin
      suidperms = 4755

v3

• Replace ${} by $() in surrounding code. [@thesamesam ]

$ git range-diff master gh/ep ep 
1:  6f4e5d61 = 1:  6f4e5d61 configure.ac, src/Makefile.am: Follow GNU coding standards regarding directory variables
-:  -------- > 2:  0fada16b src/Makefile.am: Use $() for consistency

v3b

• Rebase

$ git range-diff master..gh/ep shadow/master..ep 
1:  6f4e5d61 = 1:  983e3308 configure.ac, src/Makefile.am: Follow GNU coding standards regarding directory variables
2:  0fada16b = 2:  8d0eb980 src/Makefile.am: Use $() for consistency

v3c

• Rebase

$ git rd
1:  983e3308 = 1:  3d09f4f9 configure.ac, src/Makefile.am: Follow GNU coding standards regarding directory variables
2:  8d0eb980 = 2:  51b0e9f9 src/Makefile.am: Use $() for consistency

[zeha]

#1227 relies on exec_prefix already being set in configure.ac; with both combined, i get this in config.h:

#define PASSWD_PROGRAM "NONE/bin/passwd"

but maybe you can just push a fix to #1227.

[alejandro-colomar]

#1227 relies on exec_prefix already being set in configure.ac; with both combined, i get this in config.h:

#define PASSWD_PROGRAM "NONE/bin/passwd"

but maybe you can just push a fix to #1227.

I bail out; too much autotools for me. @thesamesam please help. :-)

[thesamesam]

I'll look but probably tomorrow.

[thesamesam]

OK with that one change for {} vs ().

[lslebodn]

With the current state of MR, the same exec_prefix will be used for ubindir && bindir

• https://www.gnu.org/software/automake/manual/html_node/Standard-Directory-Variables.html
  So with the current state of MR ubindir == bindir and usbindir == sbindir.

Do we keepubindir and usbindir in such case?
Or they are intentionally separate in Makefile.am so one can use make variables to have different values for ubindir and bindir e.g.

make install ubindir=/tmp/bin usbindir=/tmp/sbin

Otherwise LGTM and +1 for removing hacks :-)

[alejandro-colomar]

I want to remove them, but in a separate PR. I'd say even in a separate release, just to make sure we don't break anything at some point.

[alejandro-colomar]

#1227 relies on exec_prefix already being set in configure.ac; with both combined, i get this in config.h:

#define PASSWD_PROGRAM "NONE/bin/passwd"

but maybe you can just push a fix to #1227.

Has this been fixed?