Test expiration date

[ikerexxe]

Testing for #1217

[ikerexxe]

@alejandro-colomar this is the testing for #1217. It contains all your commits there + the implementation to run getent shadow $name from the test framework + the test themselves. Do you mind taking a look to the last commit and confirm that I have tested all possible cases? Nothing else came to my mind, but you might have additional ideas.

In addition, one of the test cases (usermod -e -1 $name) returns success (0) even though the expiration date wasn't changed. Do you mind taking a look at it? I think it's a failure in the code.

Finally, does the aforementioned PR also change the date behaviour for useradd and chage? If so, I'll add additional tests for them.

[alejandro-colomar]

@alejandro-colomar this is the testing for #1217. It contains all your commits there + the implementation to run getent shadow $name from the test framework + the test themselves. Do you mind taking a look to the last commit and confirm that I have tested all possible cases? Nothing else came to my mind, but you might have additional ideas.

In addition, one of the test cases (usermod -e -1 $name) returns success (0) even though the expiration date wasn't changed. Do you mind taking a look at it? I think it's a failure in the code.

I think I commented on the one you're mentioning. Was it that one that you were referring to?

Finally, does the aforementioned PR also change the date behaviour for useradd and chage? If so, I'll add additional tests for them.

It affects all of these (since I'm changing strtoday()):

$ grep -rli strtoday 
ChangeLog
src/usermod.c
src/useradd.c
src/chage.c
lib/prototypes.h
lib/strtoday.c
lib/Makefile.am
po/POTFILES.in
NEWS

[ikerexxe]

@alejandro-colomar do you know why alpine fails when useradd/usermod/chage set the expiration date as YYYY-MM-DD? They all fail even though the date is valid (i.e. 2025-01-01).

[alejandro-colomar]

@alejandro-colomar do you know why alpine fails when useradd/usermod/chage set the expiration date as YYYY-MM-DD? They all fail even though the date is valid (i.e. 2025-01-01).

Is it a regression in my patches or is it a failure in master? Could you please open a PR without my changes, to test the tests against master?

[ikerexxe]

It's also failing without your patches. You can set up an alpine container and check it there. Can this be related to the shell they are using? If I'm being honest my knowledge in that area is very limited.

[alejandro-colomar]

It's also failing without your patches. You can set up an alpine container and check it there. Can this be related to the shell they are using? If I'm being honest my knowledge in that area is very limited.

I don't know. It might be related to the signedness of time_t, or one of those little details. I'll check this weekend when I'm back home and have better internet to create the docker container and install all the deps.