Add SM4 cipher (GB/T 32907-2016) support from SM4 enabled mbed TLS library #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For any cipher change, please go to https://github.com/shadowsocks/shadowsocks-org/issues |
|
Using SM4 for anti-censoring...This PR could definitely piss off those officers of OSCCA 🤣 |
Maybe anti-(NSA's)censoring🤣 |
|
Since the old repository I hosted my Mbed TLS fork has long gone, I republished the repository at https://github.com/Low-power/mbedtls/tree/mbedtls-2.7-sm4 for anyone interested in that. |
zonyitoo
added a commit
to shadowsocks/shadowsocks-crypto
that referenced
this pull request
Oct 23, 2023
- https://datatracker.ietf.org/doc/html/rfc8998 - shadowsocks/shadowsocks-libev#2424 If anyone interested in trying these non-standard ciphers, please take some time to get some background knowledge about the SM Cipher Suites.
zonyitoo
added a commit
to shadowsocks/shadowsocks-crypto
that referenced
this pull request
Oct 23, 2023
- https://datatracker.ietf.org/doc/html/rfc8998 - shadowsocks/shadowsocks-libev#2424 If anyone interested in trying these non-standard ciphers, please take some time to get some background knowledge about the SM Cipher Suites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
There is a SM4 cipher support for mbed TLS in pull request Mbed-TLS/mbedtls#1165 some years. Unfortunately that pull request was still left unmerged and became outdated in current mbed TLS versions; however I still managed to merge that pull request into the long term support branch 2.7, and with this minor modification to shadowsocks-libev, the SM4 ciphers appears fully functional in shadowsocks-libev.
The implemented ciphers in shadowsocks-libev are
sm4-128-cbc,sm4-128-ctrandsm4-128-gcm.Until Mbed-TLS/mbedtls#1165 can be merged, mbed TLS woudn't offically supporting SM4 cipher, however I opened this pull request for discuss whether to check a downstream version of mbed TLS of this SM4 support, in shadowsocks-libev.
My mbed TLS branch with SM4 support merged is available at https://git.nsscn.top/Low-power/mbedtls/tree/mbedtls-2.7-sm4