Fix rubocop to v1.61 #1606
Merged
Fix rubocop to v1.61 #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent linting issues with newer versions. This can prevent annoying CI failures.
Judahmeek
approved these changes
Apr 5, 2024
justin808
reviewed
Apr 5, 2024
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| module ReactOnRails | |||
| module GitUtils | |||
| def self.uncommitted_changes?(message_handler, git_installed = true) | |||
There was a problem hiding this comment.
Do only tests use this? if so, maybe we shouldn't have the option?
I'm guessing all other usages assume git is installed, and if so, then we don't need the option.
In other words, does React on Rails break if git is not installed?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time, Rubycup gets a new version and that causes CI failure for some new linting rules.
The easiest approach is to fix the version of Rubocup.
I couldn't find any reason why without fixing the version in other repos, we don't face such issues there. So my proposal here is to fix and freeze the version.
css-loaderv7, which has breaking changes.This change is