Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor serverRenderReactComponent function #1653

Merged
merged 9 commits into from
Oct 19, 2024
Merged

Refactor serverRenderReactComponent function #1653

merged 9 commits into from
Oct 19, 2024

Commits on Oct 11, 2024

  1. refactor serverRenderReactComponent

    @AbanoubGhadban
    AbanoubGhadban committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    71bba14 View commit details
    Browse the repository at this point in the history

  2. add stream package to the dummy app to fix the build problem

    @AbanoubGhadban
    AbanoubGhadban committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    448cd5d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. improve naming and organization

    @AbanoubGhadban
    AbanoubGhadban committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    fa48d6f View commit details
    Browse the repository at this point in the history

  2. don't install stream package

    @AbanoubGhadban
    AbanoubGhadban committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    033fa74 View commit details
    Browse the repository at this point in the history

  3. add a comment about building console replay before awaiting promise

    @AbanoubGhadban
    AbanoubGhadban committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    044cb13 View commit details
    Browse the repository at this point in the history

  4. make a comment clearer

    @AbanoubGhadban
    AbanoubGhadban committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    b86acd1 View commit details
    Browse the repository at this point in the history

  5. add a comment

    @AbanoubGhadban
    AbanoubGhadban committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    45b61ba View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. move some comments to another place

    @AbanoubGhadban
    AbanoubGhadban committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cdbdc86 View commit details
    Browse the repository at this point in the history

  2. make createResultObject takes renderState object

    @AbanoubGhadban
    AbanoubGhadban committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d1d9d33 View commit details
    Browse the repository at this point in the history